Fix for fake filenames in verbose traceback #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test results for commit 9f6601d merged into master
Not available for testing: python2.6 |
|
@fperez @ellisonbg @minrk: I'll merge this one this evening or tomorrow unless anyone objects. It's a fairly simple fix. |
fperez
added a commit
that referenced
this pull request
May 27, 2012
Fix for fake filenames in verbose traceback. We use in our frames fake filenames of the type `<ipython....>`, and we relied on `abspath` throwing an `OSError` exception with them. That is no longer the case, and it leads to verbose tracebacks not inspecting IPython frames correctly. This fixes the issue by simply assuming that any file that starts/ends with `</>` can't be a normal python file, which is a sensible policy (for one thing, such names can't be imported).
|
Reviewed, merged. Good job, thanks! |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix for fake filenames in verbose traceback. We use in our frames fake filenames of the type `<ipython....>`, and we relied on `abspath` throwing an `OSError` exception with them. That is no longer the case, and it leads to verbose tracebacks not inspecting IPython frames correctly. This fixes the issue by simply assuming that any file that starts/ends with `</>` can't be a normal python file, which is a sensible policy (for one thing, such names can't be imported).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing PR #1715, I noticed that the verbose traceback mode wasn't displaying variables as it should. This was because the fake filenames we use like
<ipython-input-8-90b61b657670>were being treated as real filenames. We relied onos.path.abspaththrowing anOSErrorfor them, which it no longer does.This fix assumes that any filename enclosed by
<>should be treated as not a real file. It may well be possible to create real files with such names, but it would be very bizarre, and you wouldn't be able to import them.