Use CRegExp trait for regular expressions. #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes perfect sense, thanks. I don't see how this could fail, but these are not tested quantities, so I will try to run some tests in deployment over the next few days (and possibly try to write some automated tests). |
|
Works in my basic PBS/SGE environments, so merging away, thanks! |
|
Test results for commit 5ba8058 merged into master
Not available for testing: python3.1 |
|
Test results for commit 5ba8058 merged into master
Not available for testing: |
minrk
added a commit
that referenced
this pull request
May 13, 2012
Use CRegExp trait for regular expressions in parallel launchers
|
Test results for commit 5ba8058 merged into master
Not available for testing: |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Use CRegExp trait for regular expressions in parallel launchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have this
CRegExptrait, I suppose we should use it.I've searched through the source and identified a few instances of configurable regular expressions in
parallel/apps/launcher.py.One immediate benefit is that IPython now validates the regular expression at config time instead of when the value is first used.