Catch failure in repr() for %whos #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -953,6 +953,8 @@ def type_name(v): | |||
| except UnicodeEncodeError: | |||
| vstr = unicode(var).encode(DEFAULT_ENCODING, | |||
| 'backslashreplace') | |||
| except: | |||
| vstr = "<object with id %d (str() failed)>" % id(var) | |||
There was a problem hiding this comment.
Should this say str() or repr() instead? Since depending on what an object actually implements, the error could come from either, it might be a bit more informative...
There was a problem hiding this comment.
Well, it's str() that actually failed, even if that called the object's __repr__ method. I'm conscious that the line length is limited, and I think it's sufficient information for someone who wants to fix it.
There was a problem hiding this comment.
Fair enough; merging now. Thanks!
fperez
added a commit
that referenced
this pull request
May 12, 2012
Catch failure in repr() for %whos
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Catch failure in repr() for %whos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recently reported on the mailing list, an object whose repr() fails catches out %whos. This catches the error and uses a fallback representation.