Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Dashboard improvement (necessary merge of #1658 and #1676 + fix #1492) #1739
This is merge of #1658 (alternate upload) and #1676 (shutdown fron dashboard) that were conflicting, because #1658 (alternate upload) is necessary for #1676 (shutdown fron dashboard), otherwise you can't upload file as dashbord refresh just after drag and drop...
In addition :
One small bug fix of #1658.
fixes #1492 ( bigger drag target when no notebook), it show "list is empty" when no notebooks.
finally on master.
I have tested uploading notebooks via both the button and drag and drop on linux (ubuntu 12.04) in Firefox and Chromium and it appears to be working fine in all cases.
I've confirmed that it works on Linux, and that indeed it allows uploading into Chrome when SSL is on. I double-checked that situation, and it looks like it's a chrome-specific thing (and could be just on linux), because with Firefox the d'n'd upload works fine. So this is a most welcome fix! Since it has already had good review otherwise, go for it.
My only suggestion would be to change the phrase in the dashboard
"Drag files onto the list, or click here, to import notebooks"
"To import a notebook, drag the file onto the listing below or click here."
I just think it reads better, that's all.
added a commit
this pull request
May 31, 2012
Thanks for this improvement. I think a small bug appeared when the text was changed.
hum... right, no idea why, the firefox css inspector does say that the fileinput have the right size, but dont correctly respond to click.
@fperez , should we then get back to
Mmh, I don't particularly like having to keep a contorted sentence to satisfy a bizarre browser bug... I guess if it's broken we do need to fix it, but in that case please open an issue about this so that we can return later to the problem (or somebody who knows more about browsers can). I find it truly strange that word order can affect clicking response...
From experimenting a bit with FF, it seems that it only responds to clicks in the area from the start of the sentence up to around 260 pixels, which is ~58% of the 447px input area.
So I suggest instead the following wording:
"To import a notebook, click here or drag a file onto the list below:"
Hopefully that will work.