New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard improvement (necessary merge of #1658 and #1676 + fix #1492) #1739
Conversation
refresh notebook list and cluster list when : - page get focus - every 60 sec when page is on focus stop refreshing every 60 sec when page loose focus
set kernel id to None/null if not started
don't clear list if 'upload' button are present to avoid clearing the list and the upload form
When no notebooks, show "Notebook list empty", which increase the size of the drag target. fixes ipython#1492
superseed ipython#1676 ipython#1658 (and correct bug in 1676 where one con't upload notebook because of refresh)
@fperez, can you test this branch on Linux to see if this fixes the uploadability of notebooks? (in your vast spare time ;-) |
I greatly appreciate the subtle sense of humor, @ellisonbg ;) Sure, I'll try to take this for a spin tomorrow; I'm fried for the day. Thanks for reminding me... |
I have tested uploading notebooks via both the button and drag and drop on linux (ubuntu 12.04) in Firefox and Chromium and it appears to be working fine in all cases. |
I think this is a larger issue, this appends also if the kernel dies by itself. |
@Carreau Yes you are right this change only makes it easier to expose the bug and I don't think that this |
I'll merge in a few hours if nobody as objection as it only adds some functionality and seem to work in linux. |
@Carreau : Let's give people about a day, to make sure people in California have had a chance to look at it, though I expect it will be all OK. |
I've confirmed that it works on Linux, and that indeed it allows uploading into Chrome when SSL is on. I double-checked that situation, and it looks like it's a chrome-specific thing (and could be just on linux), because with Firefox the d'n'd upload works fine. So this is a most welcome fix! Since it has already had good review otherwise, go for it. My only suggestion would be to change the phrase in the dashboard "Drag files onto the list, or click here, to import notebooks" to "To import a notebook, drag the file onto the listing below or click here." I just think it reads better, that's all. |
Ok, changed, merging then. |
Thanks for this improvement. I think a small bug appeared when the text was changed. |
Can you try to flush your browser cache,(css is often cached longer that html). I did change the size of the click area. Thanks. |
Yes I see. It works correctly in chrome. In firefox neither clearing the cache nor using a different user profile seems to work. |
hum... right, no idea why, the firefox css inspector does say that the fileinput have the right size, but dont correctly respond to click. @fperez , should we then get back to |
Mmh, I don't particularly like having to keep a contorted sentence to satisfy a bizarre browser bug... I guess if it's broken we do need to fix it, but in that case please open an issue about this so that we can return later to the problem (or somebody who knows more about browsers can). I find it truly strange that word order can affect clicking response... From experimenting a bit with FF, it seems that it only responds to clicks in the area from the start of the sentence up to around 260 pixels, which is ~58% of the 447px input area. So I suggest instead the following wording: "To import a notebook, click here or drag a file onto the list below:" Hopefully that will work. |
Dashboard improvement see ipython#1658 ipython#1676 Allow to shutdown the kernels from the dashboard, autorefresh dashboard, add a native upload method, especially for https/chrome/linux that prevent drag and drop
This is merge of #1658 (alternate upload) and #1676 (shutdown fron dashboard) that were conflicting, because #1658 (alternate upload) is necessary for #1676 (shutdown fron dashboard), otherwise you can't upload file as dashbord refresh just after drag and drop...
In addition :
One small bug fix of #1658.
fixes #1492 ( bigger drag target when no notebook), it show "list is empty" when no notebooks.
finally on master.