Tooltip completer js refactor #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8af188d.
it seem that show and hide methods fron tooltip where collinding with jquery, sometime blocking the notebook. Move from css fadeIn/Out to jQuery fade In/Out, and replace addRemoveClass by fadeIn/fadeOut
check that the cell the tooltip is giving focus back is the currently selected cell
|
This branch seems to fix the bug. I am going to merge and we an see if anything further shows up. |
ellisonbg
added a commit
that referenced
this pull request
May 18, 2012
Tooltip completer js refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ellisonbg,
This prevent the focus to be given to a non active cell.
you can change cell by clicking.
you can change cell by keyboard.
I'll be away for a few days, but still available.