New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch between hsplit and vsplit paging (request for feedback) #1747
Conversation
Right now, either hsplit or vsplit must have been used when the widget was started up.
I think being able to change between them without a command line flag is useful, but I'm not sure that ever more menu items is the right UI for it. Should we think about some sort of configuration dialog for things like this? |
A configuration dialog makes sense when we have many more options - Menus are more a more lightweight UI. With the current setup, you I'm not wed to this menu UI, but I think it's already better than what |
Of course - but there's an enormous wealth of features and options, and it would be completely overwhelming to have them all in the menu. Is this particular setting important enough to warrant a slot? It strikes me as the sort of rarely-changed option that could happily live in a settings dialog. |
The nasty complexity with a config dialog is that ultimately we'll wand that to be persisted (any decent GUI program that has a settings dialog will save your choices). But some of those options are already in our python config files. Having GUI-controlled options on top of human-editable-file ones is tricky and unpleasant to deal with. This is a bullet we'll need to bite at some point, though I'm not sure now we have the bandwidth for it... |
Since there's some disagreement here, I'm marking it as 0.14 material. |
I agree that it should be possible to switch between the different paging options in the gui. At this point I think a menu bar option would be more appropriate because folks don't necessarily expect that to live between instances (vs. a configuration window which generally seems more permanent). As for the actual code to switch between the different options, I agree that it won't be too hard to implement. |
What more is required before this can be merged? The ability to change between all paging styles on the fly? Can that be done quickly? |
Well, this is still an improvement, at least because it allows the switch. I vote for merging as is. We can still refine the UI later. |
merging in 24h if nobody object. |
qtconsole : switch between hsplit and vsplit paging
qtconsole : switch between hsplit and vsplit paging
So I hacked this together, and as long as the qtconsole was started in either
hsplit
orvsplit
modes, you can switch between them using a new "Pager" submenu.I wanted to get feedback if I should continue by trying to make it possible to switch to the default
inside
paging mode as well. It looks like it'll be a little bit involved, but doable, if it's worth having.Otherwise, I can scale this PR back to just be hsplit and vsplit switching