Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch between hsplit and vsplit paging (request for feedback) #1747

Merged
merged 2 commits into from Nov 3, 2012

Conversation

ivanov
Copy link
Member

@ivanov ivanov commented May 17, 2012

So I hacked this together, and as long as the qtconsole was started in either hsplit or vsplit modes, you can switch between them using a new "Pager" submenu.

I wanted to get feedback if I should continue by trying to make it possible to switch to the default inside paging mode as well. It looks like it'll be a little bit involved, but doable, if it's worth having.

Otherwise, I can scale this PR back to just be hsplit and vsplit switching

Right now, either hsplit or vsplit must have been used when the widget
was started up.
@takluyver
Copy link
Member

I think being able to change between them without a command line flag is useful, but I'm not sure that ever more menu items is the right UI for it. Should we think about some sort of configuration dialog for things like this?

@ivanov
Copy link
Member Author

ivanov commented May 22, 2012

A configuration dialog makes sense when we have many more options -
such as if we want to expose all of the configuration system with
knobs and dials. The thing I like about menus is that they are
discoverable. You can quickly explore all of them just with one click
on any of the menu items, and then moving your mouse around to look
through all of them.

Menus are more a more lightweight UI. With the current setup, you
click on the menu, move it to the selection, and click hsplit or
vsplit (or move on once you've checked out the options if you're just
going through checking what's in all of the menus) - that's one or two
clicks. With a configuration dialog it would be click on the menu,
click on the dialog, click on hsplit or vsplit, click to confirm your
selection - four clicks (it's still four clicks if you saw the dialog
and decided not to change hsplit/vsplit, it's a click to cancel, and
the click again to get back to the menu).

I'm not wed to this menu UI, but I think it's already better than what
we previously had.

@takluyver
Copy link
Member

Of course - but there's an enormous wealth of features and options, and it would be completely overwhelming to have them all in the menu. Is this particular setting important enough to warrant a slot? It strikes me as the sort of rarely-changed option that could happily live in a settings dialog.

@fperez
Copy link
Member

fperez commented Jun 4, 2012

The nasty complexity with a config dialog is that ultimately we'll wand that to be persisted (any decent GUI program that has a settings dialog will save your choices). But some of those options are already in our python config files. Having GUI-controlled options on top of human-editable-file ones is tricky and unpleasant to deal with.

This is a bullet we'll need to bite at some point, though I'm not sure now we have the bandwidth for it...

@fperez
Copy link
Member

fperez commented Jun 25, 2012

Since there's some disagreement here, I'm marking it as 0.14 material.

@bfroehle
Copy link
Contributor

I agree that it should be possible to switch between the different paging options in the gui. At this point I think a menu bar option would be more appropriate because folks don't necessarily expect that to live between instances (vs. a configuration window which generally seems more permanent).

As for the actual code to switch between the different options, I agree that it won't be too hard to implement.

@bfroehle
Copy link
Contributor

What more is required before this can be merged? The ability to change between all paging styles on the fly?

Can that be done quickly?

@Carreau
Copy link
Member

Carreau commented Oct 31, 2012

Well, this is still an improvement, at least because it allows the switch.

I vote for merging as is. We can still refine the UI later.

@Carreau
Copy link
Member

Carreau commented Nov 1, 2012

merging in 24h if nobody object.

Carreau added a commit that referenced this pull request Nov 3, 2012
qtconsole : switch between hsplit and vsplit paging
@Carreau Carreau merged commit 89e8cd0 into ipython:master Nov 3, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
qtconsole : switch between hsplit and vsplit paging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants