Clear window title when kernel is restarted #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When kernel is died and restarted, or restarted while it is in the busy state, message "(Busy)" on the window title is not updated. This problem is fixed by updating document title when restarting.
ellisonbg
added a commit
that referenced
this pull request
May 22, 2012
Clear window title when kernel is restarted
|
I have also removed the duplicate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kernel is died and restarted, or restarted while it is in the busy state, message "(Busy)" on the window title is not updated. This problem is fixed by updating document title when restarting.
Although I didn't make a change in the PR, I noticed that
IPython.notebook.kernel.stop_channelsis called twice in"status_dead.Kernel"hook (in notificationwidget.js) and inKernel.prototype._handle_iopub_reply. I guess it's better to remove one of them.