update zmqshell magics #1791
Merged
update zmqshell magics #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create KernelMagics object in zmqshell, and register it.
So that it can be used from other Magics without subclassing
for use notifying of kernel start (principally kernel restart)
|
Test results for commit 69ffb51 merged into master
Not available for testing: |
|
I could swear I'd gone through the zmq shell as well in the cleanup, but obviously I didn't (or forgot to commit, or messed up a rebase, who knows). In any case, thanks! Code looks clean, tests OK. Merging now. |
fperez
added a commit
that referenced
this pull request
May 31, 2012
Update zmqshell magics, this updates the API with the changes from the big magics refactor (these ones were accidentally left out in said work).
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Update zmqshell magics, this updates the API with the changes from the big magics refactor (these ones were accidentally left out in said work).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were missed in the Great Magics Reorganization.
Per a FIXME comment, I moved the
%guirefmagic into usage, and it is only loaded in theQtConsole.
Small changes needed to enable this:
CodeMagics._find_edit_targetbecame a staticmethod, so it could be used by a non-subclass.started_kernelsignal to the QtKernelManager, so frontends could notice when kernels restart.