Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition alternate upload for firefox [need cross browser/OS/language test] #1808

Merged
merged 1 commit into from May 31, 2012

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented May 31, 2012

This should bring the click area of the notebook upload more closer to the bold font in dashboard for firefox.

I don't considere it a real fix for #1806 as is also slightly shorten the area for other browser.
See also the discusion in #1739.

This include making some part of the click area more visible by changing the cursor when hovering it.

Pinging @fperez and @jenshnielsen.

I have a small technical concern :

The trick is done by overlaying a invisible "fileinput form" on top of 'click here'
But the fileinput form is made of a "input" field concatenated with a "browse" button.
I am affraid the width of the "Browse" (6 letters) button will change with language, for example in french it is a long button named "Parcourir" (9 letters)

@ellisonbg
Copy link
Member

I tested this on OS X Chrome and FF and it looks great.

@Carreau let's worry about that when we implement other languages - I am sure that there are many things we will have to change.

@Carreau
Copy link
Member Author

Carreau commented May 31, 2012

What I mean is that browse does not depend on us it depends on the user's system local (cf screen capture with opacity at 0.6 instead of 0) .
Right now in my system, I think that the size of the click area in my browser is bigger than if my system were in english.
Maybe russian Browse is only 2 letters wide...

That just something to keep in mind if people complain that the target area is smaller than click here.
screen

@ellisonbg
Copy link
Member

Ahh, I understand now.

On Thu, May 31, 2012 at 11:11 AM, Bussonnier Matthias
reply@reply.github.com
wrote:

What I mean is that browse does not depend on us it depends on the user's system local (cf screen capture with opacity at 0.6 instead of 0) .
Right now in my system, I think that the size of the click area in my browser is bigger than if my system were in english.
Maybe russian Browse is only 2 letters wide...

That just something to keep in mind if people complain that the target area is smaller than click here.
screen


Reply to this email directly or view it on GitHub:
#1808 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@fperez
Copy link
Member

fperez commented May 31, 2012

Confirming that it works very well for me, both with FF and chrome, on linux. As far as I'm concerned, go ahead and merge.

ellisonbg added a commit that referenced this pull request May 31, 2012
Reposition alternate upload for firefox [need cross browser/OS/language test]
@ellisonbg ellisonbg merged commit 5a5f16b into ipython:master May 31, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Reposition alternate upload for firefox [need cross browser/OS/language test]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants