NotebookApp: Make the number of ports to retry user configurable. #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good, thanks for the PR. I haven't tested it yet, but will try to soon. |
| @@ -97,6 +98,17 @@ def url_path_join(a,b): | |||
| else: | |||
| return a+b | |||
|
|
|||
| def random_ports(port, n): | |||
| """Generate a list of n random ports near the given port. | |||
There was a problem hiding this comment.
Probably should say that it returns a sequence not a list.
|
Other than the fact that I'm not 100% convinced this warrants an alias, this seems good to me. |
|
OK, I have tested this and it looks great. I am going to merge. |
ellisonbg
added a commit
that referenced
this pull request
Jun 1, 2012
NotebookApp: Make the number of ports to retry user configurable.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
NotebookApp: Make the number of ports to retry user configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Brian Granger's suggestion for
ipython notebook --port-retries=...in #1750.