change default extension to .ipy for %save -r #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fname, codefrom = unquote_filename(args[0]), " ".join(args[1:]) | ||
| if not fname.endswith('.py'): | ||
| fname += '.py' | ||
| if not (fname.endswith(u'.py') or fname.endswith(u'.ipy')): |
There was a problem hiding this comment.
endswith can accept a tuple of possibilities, so this can be a bit cleaner.
|
Makes sense, and looks good apart from that one tiny suggestion. |
|
Fixed. |
|
Merging as it is simple, and to keep PR number low. |
Carreau
added a commit
that referenced
this pull request
Jun 2, 2012
change default extension to .ipy for %save -r
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
change default extension to .ipy for %save -r
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well... everything in title.
I think it makes sens as most of the time, if one want to export raw history it won't be python executable...