new completer for qtconsole. #1851
Conversation
|
It looks like a cool addition. I was just trying it out and |
|
Thanks, I'll fix that, I also still have to clean some code and deduplicate some other. |
|
fix the |
|
I tested this out and functionally this is great. I really like it. The only glitch I saw is the following: when the list of completions is longer than the size of the terminal ( |
|
I'll take a look, or limit the number of completion. |
|
rebased on top of #1875 to share more code with columnize. and limit the number of completion lines to 9. |
|
Mmh, it seems to me in the last revision you forgot to add a file, perhaps? With this branch, it simply doesn't start for me at all: |
|
Sorry, I think I was tired, I rebased a remote branch that I forgot to push from work, so many things were missing, and the Should be fixed now, It also allowed me to simplifie more things. |
|
When the list of completions doesn't fit in a single group, there's no way to show the rest (and no indication there are more). How about putting at the end a 'more' entry that loads a new page? If a second page is loaded, then there should be a way to go back to the first. Try it with |
fix test that where wrong, add some others. fix ipython#1860
add a completer to the qtconsole that is navigable by arraow keys and tab. One need to call it twice to get it on focus and be able to select completion with Return. looks like zsh completer, not the gui drop down list of --gui-completer. This also try to split the completion logic from console_widget, and try to keep the old completer qui around. The plain completer that never takes focus back, and the QlistWidget completer. to switch between the 3, the --gui-completion flag as been changed to take an argument (plain, droplist, ncurses).
add a completer to the qtconsole that is navigable by arrows keys and tab. One need to call it twice to get it on focus and be able to select completion with Return. looks like zsh completer, not the gui drop down list of --gui-completer. This also try to split the completion logic from console_widget, and try to keep the old completer qui around. The plain completer that never takes focus back, and the QlistWidget completer. to switch between the 3, the --gui-completion flag as been changed to take an argument (plain, droplist, ncurses) completer also autoscroll and show `...` when rows are hidden
|
how does this look like ? I rebase and squash because the rebased on top of #1875 was painfull. |
|
I like that alot! On Sun, Jun 10, 2012 at 11:21 AM, Bussonnier Matthias
Brian E. Granger |
|
Thanks, it took me several shot to have it right. If someone want to modifie to add PgUp/PgDown, go ahead, I just need a break from this one for a few days, and i'm not ready to try to make it work 'as you type', but it should be doable. |
|
Beautiful!! You've done a terrific job here, and I commend you for it. Many thanks for your patience with all my minute requirements. I'm going to merge this now, as it's really a great improvement, to reduce the chance of conflicts. We can always do another round of improvements on it later from master. Thanks again for your great work! |
New completer for qtconsole with rich keyboard navigation during completion search. add a completer to the qtconsole that is navigable by arrows keys and tab. One need to call it twice to get it on focus and be able to select completion with Return. looks like zsh completer, not the gui drop down list of --gui-completer. This also try to split the completion logic from console_widget, and try to keep the old completer qui around. The plain completer that never takes focus back, and the QlistWidget completer. To switch between the 3, the --gui-completion flag as been changed to take an argument (plain, droplist, ncurses): ipython qtconsole --gui-completion=ncurses
|
It was really bugging me because I'm really used to it in zsh, so it is also really a relief for me to be able to See you there. |
|
On Sun, Jun 10, 2012 at 1:27 PM, Bussonnier Matthias
This is fantastic news!!
We look forward to meeting you. It's a bummer that Brian won't make Cheers, f |
New completer for qtconsole with rich keyboard navigation during completion search. add a completer to the qtconsole that is navigable by arrows keys and tab. One need to call it twice to get it on focus and be able to select completion with Return. looks like zsh completer, not the gui drop down list of --gui-completer. This also try to split the completion logic from console_widget, and try to keep the old completer qui around. The plain completer that never takes focus back, and the QlistWidget completer. To switch between the 3, the --gui-completion flag as been changed to take an argument (plain, droplist, ncurses): ipython qtconsole --gui-completion=ncurses
add a completer to the qtconsole that is navigable by arrows keys and
tab. One need to call it twice to get it on focus and be able to select
completion with Return. looks like zsh completer, not the gui drop down
list of --gui-completer.
This also try to split the completion logic from console_widget, and try
to keep the old completer qui around. The plain completer that never
takes focus back, and the QlistWidget completer.
to switch between the 3, the --gui-completion flag as been changed to
take an argument (plain, droplist, ncurses).
As I'm not 100% sure of how the completion logic in the qtconsole works, i'd like you thought/testing on it.