Fix for #1908, use os.path.normcase for safe filename comparisons #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +58,7 @@ def pyfile(fname): | |||
|
|
|||
|
|
|||
| def match_pyfiles(f1, f2): | |||
| nt.assert_equal(pyfile(f1), pyfile(f2)) | |||
| nt.assert_equal(os.path.normcase(pyfile(f1)), os.path.normcase(pyfile(f2))) | |||
There was a problem hiding this comment.
Why not put the normcase call inside pyfile? That way, all tests that call it will benefit automatically...
|
Test results for commit a353316 merged into master
Not available for testing: |
|
Test results for commit c685172 merged into master
Not available for testing: python2.6 |
|
Great, this looks clean. Thanks for the fixes, merging now! |
fperez
added a commit
that referenced
this pull request
Jun 11, 2012
Use os.path.normcase for safe filename comparisons. Closes #1908.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Use os.path.normcase for safe filename comparisons. Closes ipython#1908.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.