increase duration of save messages #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and write permanent 'failed' message to the save status area on failed save.
|
This looks clean and sensible, but we should just mark it as closing #1461, right? |
|
yes, I think so. Unless we want to hold out for a real in-your-face pop-up on failed save, but I think this is a good enough point for 0.13, so if we leave it open, we can bump it to 0.14. |
|
Sounds good. As @mcelrath commented elsewhere, we already have enough modal dialogs, let's not put more in... I was thinking today b/c of his comment that eventually we might have a little notification area/widget that's less obtrusive than popups. Merging now. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Increase duration of save messages and write permanent 'failed' message to the save status area on failed save. Not a pop-up as described in ipython#1461, but significantly more prominent, and most importantly permanent when saving fails, at least until the next successful save. Closes ipython#1461.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and write permanent 'failed' message to the save status area on failed save.
Not a pop-up as described in #1461, but significantly more prominant, and most importantly permanent when saving fails, at least until the next successful save.