remove remaining references to deprecated XREP/XREQ names #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only one line of actual code is changed. these names have been removed from the next libzmq release, and will presumably be removed from pyzmq someday.
|
Running test_pr |
|
Does this in any way change the earliest zmq version we'd support? |
|
No. The names have been deprecated for a long time,and we haven't used them anywhere in the code in forever. The only use is one that snuck into the notebook code, which was apparently unaware about the name change that had long since propagated across the rest of the code. |
|
Test results for commit 7295e82 merged into master
Not available for testing: python2.6, python3.1 |
|
OK, thanks for the clarification. Test_pr report was clean and code looks solid too, merging now. |
fperez
added a commit
that referenced
this pull request
Jun 13, 2012
Remove remaining references to deprecated XREP/XREQ names. There was only one actual use of the deprecated constants in code, but numerous mentions in docstrings, etc. These names have been removed from the next libzmq release, and will presumably be removed from pyzmq someday.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Remove remaining references to deprecated XREP/XREQ names. There was only one actual use of the deprecated constants in code, but numerous mentions in docstrings, etc. These names have been removed from the next libzmq release, and will presumably be removed from pyzmq someday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one actual use of the deprecated constants in code, but numerous mentions in docstrings, etc.
These names have been removed from the next libzmq release, and will presumably be removed from pyzmq someday.