avoid duplicate "Websockets closed" dialog on ws close #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
confirming that there's no duplicate empty dialog anymore, not sure how to test the reconnect functionality |
|
I don't know either - I though killing my wifi would do it while using a remote notebook, but it doesn't seem to. In any case, this clearly is the right change for this particular function, even if the full reconnect logic is incomplete. I'm going ahead with merge. |
minrk
added a commit
that referenced
this pull request
Jun 15, 2012
avoid duplicate "Websockets closed" dialog on ws close
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
avoid duplicate "Websockets closed" dialog on ws close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual ws close (nb shutdown) would show the real message,
immediately followed by an empty dialog.
A reconnecting message is written to the notification area
when reconnect is attempted.