Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tox (http://tox.testrun.org/) and Travis CI (http://travis-ci.org/) #1979

Merged
merged 3 commits into from Jun 20, 2012

Conversation

msabramo
Copy link
Contributor

- 2.7
- 3.2
before_install:
- easy_install readline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line must be conditional by platform, and should only be run on OS X. The equivalent would be pyreadline on Windows, and nothing on Linux.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis runs on Ubuntu, so I guess this is not needed. I probably have it because I copied from my tox.ini and I probably needed it there because I'm on OS X.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I removed the installation of readline in the latest .travis.yml.

@minrk
Copy link
Member

minrk commented Jun 20, 2012

I don't see anything left for this one. Merging away.

minrk added a commit that referenced this pull request Jun 20, 2012
@minrk minrk merged commit baa5766 into ipython:master Jun 20, 2012
@msabramo
Copy link
Contributor Author

Did you register http://travis-ci.org/#!/ipython/ipython yet? It's showing as blank for me.

@minrk
Copy link
Member

minrk commented Jun 20, 2012

I can't actually, because I don't have admin rights on this repo. I presume @fperez needs to do that.

@fperez
Copy link
Member

fperez commented Jun 20, 2012

Sorry, @minrk, I'm not following. Which action is needed that requires admin rights? I haven't ever done anything on travis-ci.org, and I don't even have an account there...

Confused, sorry.

@msabramo
Copy link
Contributor Author

http://about.travis-ci.org/docs/user/getting-started/

Basically you sign into Travis CI using GitHub OAuth and then there's a switch that you flip for your repo to turn on the GitHub service hook that talks to Travis CI.

@fperez
Copy link
Member

fperez commented Jun 20, 2012

Ah, OK. I'll take care of it tomorrow then.

@minrk
Copy link
Member

minrk commented Jun 20, 2012

It's basically just a checkbox on the hooks page - I would do it if I had access.

@fperez
Copy link
Member

fperez commented Jun 20, 2012

Needless to say, @minrk, I'm more than happy to add you to the admin group on github itself!! I just need to check the UI to see what bit needs flipping.

@fperez
Copy link
Member

fperez commented Jun 20, 2012

OK, done!

@fperez
Copy link
Member

fperez commented Jun 20, 2012

I've also created an 'Admin' team where I put you, @takluyver, @ellisonbg and myself with full admin rights on all the active repos, so we can spread the load for this kind of thing in the future and I'm not the bottleneck on anything.

So as of now, you should also be able to make these changes (not needed in this instance, of course).

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants