disable ^C^C confirmation on Windows #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the outcome on Windows then: single ^C stops the server, or is the first ^C completely ignored and the process needs a different kill mechanism? |
|
single ^C does a regular clean exit. |
|
Ok, then that sounds good, thanks for catching this one! Merging now. |
fperez
added a commit
that referenced
this pull request
Jun 25, 2012
disable ^C^C confirmation on Windows since it uses select.select on stdin, which is illegal on Windows.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
disable ^C^C confirmation on Windows since it uses select.select on stdin, which is illegal on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it uses select.select on stdin, which is illegal on Windows.