increase auto-scroll threshold to 100 lines #2042
Conversation
prevented case-sensitive shortcuts if shift was pressed after control key
|
Mmh, 120 feels a bit long to me... Even on a large monitor it starts to make cells really big. Were you finding in practice the previous threshold too low? I was kind of happy with it... |
|
I'm mainly thinking of what happens if we guess wrong. If our threshold is too high, we do nothing, and users scroll the long output they wish we had (only bonus). If our threshold is too low, we are hiding output the user wishes we wouldn't, and they have to undo what we did that they are unhappy with. This produces an adversarial relationship with the notebook. I think 50 is closer to ideal (probably too short, especially on large monitors), but it seems more important to be conservative when triggering actions users will want to undo. Basically, I think we should only be auto-scrolling output that is too long, not just output that is pretty long. |
|
Want to revise it down just a bit, around 80 or 100? That feels already comfortably in the 'too long' category to me, though I agree with your basic philosophy here. |
it is more important that we not be surprising or annoying than we hide moderately long output.
|
Bumped down to 100. I'm not sure I would want it lower than that, at least until we have a user-facing preferencePane where users can change it. |
|
Sounds good, let's get this in now. Thanks! Merging. |
Increase auto-scroll threshold to 100 lines.
It is more important that we not be surprising or annoying than we auto-hide moderately long output. The manual toggle is always available for intermediate outputs.
Also explicitly ignore shift keydown in our keycode handler, which prevented the sequence:
<ctrl> M <shift> o
from being recognized, as the shift keypress would reset the control-key state.
|
Just for completeness, this was prompted by annoyance on IRC at the auto-scrolling for what were considered reasonably-sized output. |
|
Ah, OK: good to know there was specific feedback in this direction, that's what I was wondering about. Happy with the change. |
Increase auto-scroll threshold to 100 lines.
It is more important that we not be surprising or annoying than we auto-hide moderately long output. The manual toggle is always available for intermediate outputs.
Also explicitly ignore shift keydown in our keycode handler, which prevented the sequence:
<ctrl> M <shift> o
from being recognized, as the shift keypress would reset the control-key state.
It is more important that we not be surprising or annoying than we auto-hide moderately long output. The manual toggle is always available for intermediate outputs.
Also explicitly ignore shift keydown in our keycode handler, which prevented the sequence:
from being recognized, as the shift keypress would reset the control-key state.