open notebook copy in different tabs

[Carreau]

use time since epoch to avoid reusing the same tab
fixes #2120
as long as one dos not open more that one tab per second.

[ellisonbg]

This looks great.

[minrk]

I think this is the wrong approach. The target should just be _blank, which is always a new tab/window. No sensitivity to time or anything.

[ellisonbg]

So what is causing it to open in the same tab then?

On Thu, Jul 12, 2012 at 8:56 AM, Min RK
reply@reply.github.com
wrote:

I think this is the wrong approach. The target should just be _blank, which is always a new tab/window. No sensitivity to time or anything.

---

Reply to this email directly or view it on GitHub:
#2128 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[ellisonbg]

I could swear that it used to work perfectly.

On Thu, Jul 12, 2012 at 9:00 AM, Brian Granger ellisonbg@gmail.com wrote:

So what is causing it to open in the same tab then?

On Thu, Jul 12, 2012 at 8:56 AM, Min RK
reply@reply.github.com
wrote:

I think this is the wrong approach. The target should just be _blank, which is always a new tab/window. No sensitivity to time or anything.

---

Reply to this email directly or view it on GitHub:
#2128 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

[Carreau]

it does the same with _blank if any of the main page or its fork call window.open(url,'_blank') it will load in the forked tabs.

[Carreau]

Note that it works the first time correctly but not afterward, as if _newtab was an identifier of the newly open tab.
You can try from js console in any website, it does the same. That not from our side.

[Carreau]

Also I used time to be sure to have 2 different number, I can write a randint function but that's more line of code and overkill.

[minrk]

@Carreau - that is not true of _blank. _blank is a special identifier, and you can click on the same link a hundred times and it will open a hundred new tabs.

For example:

target=_new_tab

target=_blank

[Carreau]

@minrk
That was my first thought; but I tried and it wasn't working... I might have mistyped, i'll try again.

[Carreau]

So my bad, I should have misstype, but I can swear that this was the first thing I tryed.
updated and force pushed.
A ended with a return false otherwise ctrl-click open both the copy and the curent notebook in 2 new tabs.
It has the side effect of opening in a new tab instead of a new window also.
I let you merge.

[minrk]

No worries.

This looks good to me now. Thanks!

[Carreau]

cool, merging !