[2to3 compat ] Tuple params in func defs #2158
Conversation
| @@ -204,10 +204,10 @@ def format2(self, raw, out = None, scheme = ''): | |||
| return (output, error) | |||
| return (None, error) | |||
|
|
|||
| def __call__(self, toktype, toktext, (srow,scol), (erow,ecol), line): | |||
| def __call__(self, toktype, toktext, s_tuple, e_tuple, line): | |||
There was a problem hiding this comment.
Can we come up with a better name? I haven't read the function, but my first guess would be start and end? Or spos, epos? Or..
There was a problem hiding this comment.
changed to (start | end)_pos squashed and force pushed.
|
Okay looks good to me. 2to3 doesn't report any other instances of this tuple parameter construction. |
|
Test results for commit 82a4930 merged into master
Not available for testing: python2.6, python3.1 |
|
Looks good to me. Merge at your leisure. |
|
Sorry, i' don't have the habit of using test_pr as |
Remove tuple auto unpack in function definition This is for 2to3 compatibility., and also deactivate the application of the corresponding 2to3 fix when using python3 and setup.py.
|
That's OK, it's designed so anyone can easily run it, so it doesn't have to be the author. Is it a proxy that's causing the problem? I remember the pain of being forced to access the net through a proxy, but happily I no longer need to. |
|
Yes, dumb proxy, open only on 80 et 443 .... that's also what prevent me from using |
|
Shouldn't 80 & 443 cover what you need here? Or is requests ignoring |
|
Yes i've an opened issue , but hasn't been fixed yet. I would guess this is bad proxy config from the IT guys where I work. It took them 3 month to understand what rsync was and to accept to open a port that was close a week later... |
Remove tuple auto unpack in function definition This is for 2to3 compatibility., and also deactivate the application of the corresponding 2to3 fix when using python3 and setup.py.
See pep 3113.