New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FileFindHandler for Notebook static files #2175
Conversation
adds NotebookApp.extra_static_paths configurable for extending the search path. The default is to include profile/static.
With FileFindHandler, these will be useful for small user overrides of css/js.
The destination is now configurable, and the default no longer requires admin access. Also defaults to current mathjax 2.0
hum, this is completely broken for me.
otherwise it say that path is a list and have no attributes also I guess there is a commit missing ? |
It works for me, so maybe it is a tornado version thing. I will look into doing this more carefully, and checking against various tornado versions.
get must not be authenticated, or you would not even be able to see the login page without having logged in already. The default StaticFileHandler does not authenticate. |
here is the traceback of tornado. and I pushed a crude thing of copy/past/things I did to make it works in also
|
|
Thanks, I will look more carefully at the diff between our baseline dependency (2.1.0) and 2.2-dev, and push again in the next day or two. |
tested against 2.1.0, and fixed by pulling a few more methods from current tornado verbatim. |
Great ! I'll test that ! It'll be cool to load js extension ! |
That's perfect, don't even need to provide user-custom templates as you can just inject any other change or file you want into the page with The only issues I see is that you might hate to install things on every profiles. Does windows allows stuff like symlinks ? |
ha ! I didn't saw the |
add FileFindHandler for Notebook static files * The static file handler now uses a search path, instead of a single dir. This allows easier customization of available js/css, and provides a place for extra files to go for extending the notebook. * An empty custom.js / custom.css are added to the templates for trivial custom user styling/scripting. The search only happens once, and the result is cached after the first. * A few methods are pulled from tornado 2.2-dev verbatim to have tornado 2.1 compatibility. * mathjax is now installed by default in profile.
i'll merge this guy which is great. |
add FileFindHandler for Notebook static files * The static file handler now uses a search path, instead of a single dir. This allows easier customization of available js/css, and provides a place for extra files to go for extending the notebook. * An empty custom.js / custom.css are added to the templates for trivial custom user styling/scripting. The search only happens once, and the result is cached after the first. * A few methods are pulled from tornado 2.2-dev verbatim to have tornado 2.1 compatibility. * mathjax is now installed by default in profile.
The static file handler now uses a search path, instead of a single dir.
This allows easier customization of available js/css,
and provides a place for extra files to go for extending the notebook.
An empty custom.js / custom.css are added to the templates for trivial custom user styling/scripting.
The search only happens once, and the result is cached after the first.