Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust how canning deals with import strings #2222

Merged
merged 1 commit into from Aug 1, 2012
Merged

adjust how canning deals with import strings #2222

merged 1 commit into from Aug 1, 2012

Conversation

minrk
Copy link
Member

@minrk minrk commented Jul 30, 2012

  • imports should only happen once
  • errors should only be logged when user imports fail (not systems without numpy)

@minrk
adjust how canning deals with import strings
4bca5d9 
* imports should only happen once
* errors should only be logged when *user* imports fail (not no-numpy)
@Carreau
Copy link
Member

Carreau commented Aug 1, 2012

OK for me, I let you merge.

@minrk
Copy link
Member Author

minrk commented Aug 1, 2012

Test results for commit 4bca5d9 merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py rpy2 wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 wx wx.aui)

Not available for testing:

minrk added a commit that referenced this pull request Aug 1, 2012
@minrk
Merge pull request #2222 from minrk/canning
14006db 
adjust how canning deals with import strings

* imports should only happen once
* errors should only be logged when *user* imports fail (not systems without numpy)
@minrk minrk merged commit 14006db into ipython:master Aug 1, 2012
@minrk minrk deleted the canning branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@minrk
Merge pull request ipython#2222 from minrk/canning
9e6d16d 
adjust how canning deals with import strings

* imports should only happen once
* errors should only be logged when *user* imports fail (not systems without numpy)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@minrk @Carreau