minor test_pr tweaks #2236
Merged
minor test_pr tweaks #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minrk
commented
Aug 2, 2012
minrk
commented
- pipe install stdout to file, because it is annoying
- time install step, because why not?
- pull from origin on first try, to avoid 'your branch is ahead of origin/master' messages
The vast majority of the output of test_pr is uninteresting stdout for install. It's also possible for system-site-packages envs to end up importing IPython *not* from the install we mean to test, so add a check for that.
prevents 'your branch is ahead of origin/master by xx commits' messages from growing over time.
|
Test results for commit f019685 merged into master
Not available for testing: python2.6 |
|
Those tests were run with test_pr from this branch. Everything seems to make sense, so I'll merge this. Thanks. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
minor test_pr tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.