Fast tests #2238
Fast tests #2238
Conversation
| @@ -22,7 +22,7 @@ def test(): | |||
| # Do the import internally, so that this function doesn't increase total | |||
| # import time | |||
| from iptest import run_iptestall | |||
| run_iptestall() | |||
| run_iptestall(inc_slow=all) | |||
There was a problem hiding this comment.
oups sorry , read to fast never mind
There was a problem hiding this comment.
bikeshedding, but probably easier to understand in the negative, i.e skip_slow.
There was a problem hiding this comment.
My preferred shade of bikeshed is that it's logically consistent with the command line option (--all). But as a parameter to run_iptestall, all doesn't seem very descriptive, so it became inc_slow.
|
Test results for commit f19ae9e merged into master
Not available for testing: python2.6 |
|
That was just the fast tests - slow tests coming up. |
| @@ -156,6 +159,9 @@ def print_results(self): | |||
| print(" Test log:", result.get('log_url') or result.log_file) | |||
| if result.missing_libraries: | |||
| print(" Libraries not available:", result.missing_libraries) | |||
|
|
|||
| if self.extra_args: | |||
| print("Extra args:", self.extra_args) | |||
| print("Not available for testing:", ", ".join(self.unavailable_pythons)) | |||
There was a problem hiding this comment.
else :
print 'No extra Arguments'
?
So that we are reminded that it is the slow one ?
There was a problem hiding this comment.
It's not very meaningful unless the users knows what arguments there are, though, and I'm aiming for test_pr to know as little as possible about the specifics of what it's testing. I think I prefer to keep the output cleaner.
I think the important thing is the entry in the Github comment, so that if a PR touches anything that could affect IPython.parallel, reviewers can see that it's got a test run with --all.
|
Test results for commit f19ae9e merged into master
Extra args: ['--all'] |
|
Damned, I'm not receiving the github notification anymore... |
Fast Test See #2026. By default `iptest` will only run the faster tests, and `iptest --all` is necessary to run all of them. At present, it just cuts out `IPython.parallel`, but we can refine that if we want to. `test_pr` is also updated so that you can pass extra arguments through to iptest.
|
For now, I'll tweak ShiningPanda to keep doing a full run every night. But we'll have the option handy if we want to free up some more time. |
Fast Test See ipython#2026. By default `iptest` will only run the faster tests, and `iptest --all` is necessary to run all of them. At present, it just cuts out `IPython.parallel`, but we can refine that if we want to. `test_pr` is also updated so that you can pass extra arguments through to iptest.
See #2026.
As Min suggested,
iptestby default will only run the faster tests, andiptest --allis necessary to run all of them. At present, it just cuts outIPython.parallel, but we can refine that if we want to.test_pris also updated so that you can pass extra arguments through to iptest.