Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix message built for engine dying during task #2240

Merged
merged 3 commits into from Sep 27, 2012

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 3, 2012

The test_z_<foo>_crash tests actually test this, but they have long-since been skipped because people don't like the crash dialogs some OSes give.

@minrk
Copy link
Member Author

minrk commented Aug 4, 2012

Test results for commit 88d0730 merged into master
Platform: darwin

  • python2.6: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 tornado wx wx.aui)
  • python2.7: OK (libraries not available: oct2py rpy2 wx wx.aui)
  • python3.2: OK (libraries not available: cython matplotlib oct2py pygments pymongo qt rpy2 wx wx.aui)

Not available for testing:

@fperez
Copy link
Member

fperez commented Aug 5, 2012

I wonder if we shouldn't instead tag those tests with a 'crash' label, omit them by default, but occasionally run them ourselves. We wouldn't expect regular users to run them all the time, but core devs could do so when desired.

The test_z_<foo>_crash tests actually test this, but they have long-since been skipped because people don't like the crash dialogs some OSes give.
instead of simply Skipping
@minrk
Copy link
Member Author

minrk commented Aug 11, 2012

I marked the crash tests with @attr('crash'), and then tweaked iptest, such that if no -a args are specified, then it is equivalent to iptest -a '!crash'. To run the crash tests, you can do iptest -a crash IPython.parallel. To run them all, I can't see a better way than iptest -a crash -a '!crash', given how nose handles tag-based selection (it only seems to do selection, not exclusion).

I think we can make use of tags to improve @skip_doctest, so that 'skipped' doctests do not show up as passing tests, as they do now, but it's not quite obvious to me precisely how.

@bfroehle
Copy link
Contributor

Another option would be to use an environment flag, e.g. IPTEST_... to control whether or not these tests are skipped. This would avoid the issue of needing to remember the -a '!crash' flag.

minrk added a commit that referenced this pull request Sep 27, 2012
fix message built for engine dying during task

would result in KeyError on missing 'metadata'
@minrk minrk merged commit b3a8513 into ipython:master Sep 27, 2012
@minrk minrk deleted the stranded_metadata branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
fix message built for engine dying during task

would result in KeyError on missing 'metadata'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants