use Singleton.instance() for embed() instead of manual global #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any use of get_ipython() could cause funky misbehaving, potentially invoking another InteractiveShell instance. One change is calling IPython.embed() from inside a running IPython session will now result in a MultipleInstanceError. closes ipython#1884
|
Yup, way cleaner. Thanks! Merging now. |
fperez
added a commit
that referenced
this pull request
Sep 6, 2012
use Singleton.instance() for embed() instead of manual global
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
use Singleton.instance() for embed() instead of manual global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any use of get_ipython() could cause funky misbehaving,
potentially invoking another InteractiveShell instance.
One change is calling IPython.embed() from inside a running IPython session will now result in a MultipleInstanceError.
closes #1884