Don't catch ImportError when trying to unpack module functions #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the ImportError is encountered, it is more informative to raise it rather than hide it, possibly resulting in confusing NameErrors due to the import failure.
|
Test results for commit 46ee6cb merged into master (a743924)
Extra args: ['-x', '--all'] |
|
ok for me. |
|
I'm merging this one. |
Carreau
added a commit
that referenced
this pull request
Sep 29, 2012
Don't catch ImportError when trying to unpack module functions
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Don't catch ImportError when trying to unpack module functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ImportError is encountered, it is more informative to raise it rather than hide it, possibly resulting in confusing NameErrors due to the import failure.