add IPython version to message headers #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always-comparable tuple for IPython versions Note that types for each slot must never differ, due to Python 3 breaking loose comparisons (0 is used for base micro, never '')
| @@ -187,6 +187,7 @@ def __getitem__(self, k): | |||
|
|
|||
| def msg_header(msg_id, msg_type, username, session): | |||
| date = datetime.now() | |||
| version = IPython.version_info() | |||
There was a problem hiding this comment.
NameError: global name 'IPython' is not defined
There was a problem hiding this comment.
Oops, I forgot I had made a pull request from this. Fixed.
will allow future logic to make appropriate compatibility checks
|
Ok for merge. |
bfroehle
added a commit
that referenced
this pull request
Sep 18, 2012
add IPython version to message headers
|
Looks good to me. Merged. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
add IPython version to message headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will allow future logic to make appropriate compatibility checks