New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some notebook tweaks. #2421
Some notebook tweaks. #2421
Conversation
I am probably -1 on this. In my mind the benefit of the notebook is that we are free from the constraints of the console look and feel. In a terminal/console context, the continuation prompts serve a real purpose - to help the user line up additional lines of code. In the notebook,that purpose is served by the shading of the input area so continuation prompts only add visual clutter. A few other points:
|
My point is not on transforming the notebook into a console. Don't worry. I also think that we'll came to a point where people will brand the notebook, or may not like the cell "shading". To be clear, the "visible part" of this PR only shift the output area of a few pixel to top left. The rest is a convenient ability to modifie prompt for codecell, The upper capture if what could be done with ~10 lines of js/css if one would like a more "console like" webinterface. (who is thinking of embedded webkit...) which is easier to achieve with theses changes. A long time goal would be to have most of the Js shared and why not have an Does that makes more sens ? |
OK thanks for clarifying this. As long as the default look/feel of the On Sun, Sep 23, 2012 at 3:25 PM, Bussonnier Matthias <
Brian E. Granger |
input and output vertically alligned now. Same with base text of output prompt which is now aligned with text.(used to be 1px difference, pager as guide.)
No, not yet. It is mainly for configuration/extension purposes to avoid having to re-write it. |
input is off in exactly the same way as output, if you want them to match. |
Do you mean horizontal alignment? I don't see any vertical shift in the before and after. Sent from my iPad On Sep 25, 2012, at 7:36 AM, Bussonnier Matthias notifications@github.com wrote:
|
Vertical alignment - there is a tiny shift in vertical alignment in the output area, but the vertical alignment was exactly the same in the input area, so if one should be fixed, so should the other. |
Well I guess it is not, because you have different number of nested tags. Just look as the screen capture.
1px shift you really need to zoom in
The border of codemirror is 1px wide, I believe it does introduce a 1px shift. At least I have the 1px shift in output and not in input. |
I think we are all looking at and seeing different things. Matthias, do On Wed, Sep 26, 2012 at 4:41 AM, Bussonnier Matthias <
Brian E. Granger |
@@ -238,7 +238,7 @@ div.output_area { | |||
/* This class is for the output subarea inside the output_area and after | |||
the prompt div. */ | |||
div.output_subarea { | |||
padding: 0.4em 0.4em 0.4em 0.4em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the PR is fine.
Good call on doing the codemirror config separately. This looks good now, merging. |
Some notebook tweaks.
I'm looking at wether I can make the notebook more "console-like"
( tweeked notebook vs qtconsole )
So here are 3 little changes (to start) that would make the customization a little easier.
Allow easier prompt customization with continuation prompt.
Add a convenient 'insert_cell_at_bottom' function
And slightly tweak css so that Input and Ouput are better aligned vertically.