allow iptest to be interrupted #2442
Merged
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `^C` would register as a regular test failure, and the test suite would continue, in which case halting `iptest` meant hitting `^C` nine times. This change makes iptest take notice of sigint in a test runner, and aborts the run.
|
Oooh yes! A great improvement. Works as claimed for me in Ubuntu 12.04 / Python 2.7.3. |
|
cool, merging. |
Carreau
added a commit
that referenced
this pull request
Sep 28, 2012
allow iptest to be interrupted
|
Thanks, that's a minor annoyance I've met quite often as well. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
allow iptest to be interrupted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
^Cwould register as a regular test failure and the test suite would continue, in which case interruptingiptestmeant hitting^Cnine times.This change makes iptest take notice of sigint in a test runner, and aborts the run.