Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctest_run_option_parser for Windows #2478

Merged
merged 2 commits into from Oct 29, 2012

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Oct 9, 2012

It should fix (part of) #2477.

@takluyver
Copy link
Member

We need a Windows user to test this. @jstenar , will you have time in the next few days?

@bfroehle
Copy link
Contributor

I'd be in favor of a simple decorator with a known failure warning on non-posix systems

@dec.knownfailureif(os.name != 'posix', 'This test is known to fail on non-POSIX systems.')

@tkf
Copy link
Contributor Author

tkf commented Oct 23, 2012

You mean use that decorator for doctest_run_option_parser_for_windows? But passing doctest_run_option_parser_for_posix means failing doctest_run_option_parser_for_windows. I think known failure is for something like "if you fix this bug, this failure goes away". But in this case, if you fix the problem in POSIX system, you need to remove doctest_run_option_parser_for_posix as it will fail if %run behaves the way we want.

@ghost
Copy link

ghost commented Oct 23, 2012

tested to have fixed the doctests failure on py2.7/win7.

@takluyver , shouldn't ShiningPanda have taken care of windows testing for you?

@takluyver
Copy link
Member

ShiningPanda is set up to run tests on master. You can point it to other branches, but it has to be manually reconfigured. Travis-CI automatically runs the tests on each pull request, but that's only on Linux.

@ghost
Copy link

ghost commented Oct 23, 2012

That's too bad, it looks like windows testing is a recurring problem. Perhaps permanently adding a few
free-for-all integration branches to throw patches into, test, then revert back to master would help
things move more quickly.



@dec.skip_linux
@dec.skip_osx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a skip_if_not_win32 decorator we could use.

@tkf
Copy link
Contributor Author

tkf commented Oct 29, 2012

@takluyver fixed.

@takluyver
Copy link
Member

Thanks @tkf . I'll merge this, so hopefully we'll have the Windows tests passing again.

takluyver added a commit that referenced this pull request Oct 29, 2012
Fix doctest_run_option_parser for Windows
@takluyver takluyver merged commit b85ec6f into ipython:master Oct 29, 2012
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Fix doctest_run_option_parser for Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants