New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doctest_run_option_parser for Windows #2478
Conversation
It should fix (part of) ipython#2477.
We need a Windows user to test this. @jstenar , will you have time in the next few days? |
I'd be in favor of a simple decorator with a known failure warning on non-posix systems @dec.knownfailureif(os.name != 'posix', 'This test is known to fail on non-POSIX systems.') |
You mean use that decorator for |
tested to have fixed the doctests failure on py2.7/win7. @takluyver , shouldn't ShiningPanda have taken care of windows testing for you? |
ShiningPanda is set up to run tests on master. You can point it to other branches, but it has to be manually reconfigured. Travis-CI automatically runs the tests on each pull request, but that's only on Linux. |
That's too bad, it looks like windows testing is a recurring problem. Perhaps permanently adding a few |
|
||
|
||
@dec.skip_linux | ||
@dec.skip_osx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a skip_if_not_win32
decorator we could use.
@takluyver fixed. |
Thanks @tkf . I'll merge this, so hopefully we'll have the Windows tests passing again. |
Fix doctest_run_option_parser for Windows
Fix doctest_run_option_parser for Windows
It should fix (part of) #2477.