fix jinja2 rendering for password protected notebooks #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I installed ipython-notebook from Julian Taylor's ppa today, and keep getting some error about jinja2 endblock; maybe this pull request will fix my issue? (fingers crossed) |
| @@ -225,7 +226,7 @@ class LoginHandler(AuthenticatedHandler): | |||
| def _render(self, message=None): | |||
| template = self.application.jinja2_env.get_template('login.html') | |||
| self.write( template.render( | |||
| next=self.get_argument('next', default=self.application.ipython_app.base_project_url), | |||
| next=tornado.escape.url_escape(self.get_argument('next', default=self.application.ipython_app.base_project_url)), | |||
There was a problem hiding this comment.
tornado.escape is only available here because importing web and websocket imports escape, whereas doing just import tornado does not. We should be explicit and either import tornado.escape or from tornado.escape import url_escape
|
Great, merging now that comments are fix... let's taget < 30 opened PRs... |
Carreau
added a commit
that referenced
this pull request
Dec 19, 2012
fix jinja2 rendering for password protected notebooks
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix jinja2 rendering for password protected notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the jinja2 rendering for ipython notebooks and runs the url_escape function in python since there is no equivalent in jinja2.