try to fallback to pysqlite2.dbapi2 as sqlite3 in core.history

[skyl]

for situations where Python is built without sqlite3 and
can not easily be changed, it would be nice to still be
able to get history with pysqlite2.

[Carreau]

Do we have guaranties that the api will be the same ?

I don't like importing as sqlite3 as later you don't know that sqlite3 is not effectively sqlite3

Maybe importing both as history_db and change sqlite3 references across all file ?

[takluyver]

The database API is supposed to be consistent, so I think importing as
sqlite3 is OK. Changing the name across the file would make the code harder
to read, and leaves more chances for bugs to sneak in.

Skylar, have you tested it with pysqlite2, both manually and by running
iptest?

On 24 December 2012 11:46, Bussonnier Matthias notifications@github.comwrote:

In IPython/core/history.py:

@@ -20,7 +20,10 @@
try:
import sqlite3
except ImportError:

• sqlite3 = None
• try:

•    from pysqlite2 import dbapi2 as sqlite3
  

Do we have guaranties that the api will be the same ?

I don't like importing as sqlite3 as later you don't know that sqlite3 is
not effectively sqlite3

Maybe importing both as history_db and change sqlite3 references across
all file ?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2718/files#r2497725.

[minrk]

I disabled sqlite3 and ran iptest, and played around interactively, and this seems to work just fine.

[Carreau]

Merging as this seem to be ok.