Rmagic: error message when moving an non-existant variable from python to R #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, I think this makes sense. |
bfroehle
added a commit
that referenced
this pull request
Jan 3, 2013
Rmagic: error message when moving an non-existant variable from python to R
|
Thanks. |
jenshnielsen
added a commit
to jenshnielsen/ipython
that referenced
this pull request
Jan 3, 2013
bfroehle
added a commit
that referenced
this pull request
Jan 3, 2013
Fix tests for rmagic (KeyError -> NameError). Caused by #2737.
minrk
pushed a commit
to minrk/ipython
that referenced
this pull request
Jan 26, 2013
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Rmagic: error message when moving an non-existant variable from python to R
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix tests for rmagic (KeyError -> NameError). Caused by ipython#2737.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you try to push a non-existant python variable to R, you get a
KeyErrorMaybe the error message could be more intuitive? The fact that local variables are stored in a dict (thus generating a
KeyError) is kind-of an implementation detail.In regular python, using an undefined variable name generates a
NameError-- perhaps that would also be the appropriate error to raise in this case?This PR changes the error to: