Allow shutdown when no engines are registered #2769
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following code demonstrates the problem: from IPython.utils.path import locate_profile
from IPython.parallel.apps.launcher import LocalControllerLauncher
from IPython.parallel import Client
controller = LocalControllerLauncher(profile_dir=locate_profile())
controller.start()
try:
rc = Client()
rc.shutdown()
rc.shutdown(hub=True)
finally:
controller.stop()
# |
|
Looks clear and right to me. |
minrk
added a commit
that referenced
this pull request
Jan 10, 2013
Allow shutdown when no engines are registered
minrk
added a commit
that referenced
this pull request
Mar 5, 2013
When no engines are registered the `Client.shutdown` method raises a `NoEnginesRegistered` exception. This occurs before the hub shutdown thus preventing the hub from being shutdown.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Allow shutdown when no engines are registered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no engines are registered the
Client.shutdownmethod raises aNoEnginesRegisteredexception.This occurs before the hub shutdown thus preventing the hub from being shutdown.