Skip to content

Prefilter shouldn't touch execution_count #2783

Merged
merged 1 commit into from Jan 14, 2013

3 participants

@takluyver
IPython member

Having gone through the various things that can call it, I'm pretty sure that there's no need for prefilter to be modifying the execution/prompt counter. And in testing, I can't construct an example that hits this bit of code.

If we agree on this, it supersedes #2623.

@bfroehle

My testing pointed in this direction as well, but I also couldn't construct an example that hit this bit of code.

@ellisonbg
IPython member

This is probably leftover from really long ago. If both of you have tested this, I would go ahead and merge.

@takluyver
IPython member

Thanks, I'll do that.

@takluyver takluyver merged commit c004aa6 into ipython:master Jan 14, 2013

1 check passed

Details default The Travis build passed
@minrk minrk added a commit that referenced this pull request Mar 5, 2013
@minrk minrk Backport PR #2783: Prefilter shouldn't touch execution_count
Having gone through the various things that can call it, I'm pretty sure that there's no need for prefilter to be modifying the execution/prompt counter. And in testing, I can't construct an example that hits this bit of code.

If we agree on this, it supersedes #2623.
1d9f2d9
@takluyver takluyver referenced this pull request Mar 23, 2013
Closed

Bug handling Ellipsis #3061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.