Prefilter shouldn't touch execution_count #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My testing pointed in this direction as well, but I also couldn't construct an example that hit this bit of code. |
|
This is probably leftover from really long ago. If both of you have tested this, I would go ahead and merge. |
|
Thanks, I'll do that. |
takluyver
added a commit
that referenced
this pull request
Jan 14, 2013
…n-count Prefilter shouldn't touch execution_count
minrk
added a commit
that referenced
this pull request
Mar 5, 2013
Having gone through the various things that can call it, I'm pretty sure that there's no need for prefilter to be modifying the execution/prompt counter. And in testing, I can't construct an example that hits this bit of code. If we agree on this, it supersedes #2623.
Closed
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
…xecution-count Prefilter shouldn't touch execution_count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having gone through the various things that can call it, I'm pretty sure that there's no need for prefilter to be modifying the execution/prompt counter. And in testing, I can't construct an example that hits this bit of code.
If we agree on this, it supersedes #2623.