Prefilter shouldn't touch execution_count #2783

Merged
merged 1 commit into from Jan 14, 2013

Conversation

Projects
None yet
3 participants
@takluyver
Member

takluyver commented Jan 13, 2013

Having gone through the various things that can call it, I'm pretty sure that there's no need for prefilter to be modifying the execution/prompt counter. And in testing, I can't construct an example that hits this bit of code.

If we agree on this, it supersedes #2623.

@bfroehle

This comment has been minimized.

Show comment
Hide comment
@bfroehle

bfroehle Jan 13, 2013

Contributor

My testing pointed in this direction as well, but I also couldn't construct an example that hit this bit of code.

Contributor

bfroehle commented Jan 13, 2013

My testing pointed in this direction as well, but I also couldn't construct an example that hit this bit of code.

@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Jan 14, 2013

Member

This is probably leftover from really long ago. If both of you have tested this, I would go ahead and merge.

Member

ellisonbg commented Jan 14, 2013

This is probably leftover from really long ago. If both of you have tested this, I would go ahead and merge.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Jan 14, 2013

Member

Thanks, I'll do that.

Member

takluyver commented Jan 14, 2013

Thanks, I'll do that.

takluyver added a commit that referenced this pull request Jan 14, 2013

Merge pull request #2783 from takluyver/prefilter-dont-touch-executio…
…n-count

Prefilter shouldn't touch execution_count

@takluyver takluyver merged commit c004aa6 into ipython:master Jan 14, 2013

1 check passed

default The Travis build passed
Details

minrk added a commit that referenced this pull request Mar 5, 2013

Backport PR #2783: Prefilter shouldn't touch execution_count
Having gone through the various things that can call it, I'm pretty sure that there's no need for prefilter to be modifying the execution/prompt counter. And in testing, I can't construct an example that hits this bit of code.

If we agree on this, it supersedes #2623.

@takluyver takluyver referenced this pull request Mar 23, 2013

Closed

Bug handling Ellipsis #3061

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #2783 from takluyver/prefilter-dont-touch-executio…
…n-count

Prefilter shouldn't touch execution_count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment