Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code #2799

Merged
merged 2 commits into from Jan 18, 2013
Merged

Exit code #2799

merged 2 commits into from Jan 18, 2013

Conversation

takluyver
Copy link
Member

Correct the exit code to be a simple value, rather than two or three separate values stuffed into a single integer.

Closes issue #2794.

My reading of the Windows docs is that the test I've added should work on Windows as well.

@minrk
Copy link
Member

minrk commented Jan 18, 2013

I ran the test on Windows (7x64), and it works as expected.

Merging away.

minrk added a commit that referenced this pull request Jan 18, 2013
fix `_exit_code` after running system calls

Correct the exit code to be a simple value, rather than two or three separate values stuffed into a single integer.

Closes #2794
@minrk minrk merged commit 7e89099 into ipython:master Jan 18, 2013
minrk added a commit that referenced this pull request Mar 5, 2013
Correct the exit code to be a simple value, rather than two or three separate values stuffed into a single integer.

Closes issue #2794.

My reading of the [Windows docs](http://www.microsoft.com/resources/documentation/windows/xp/all/proddocs/en-us/exit.mspx?mfr=true) is that the test I've added should work on Windows as well.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
fix `_exit_code` after running system calls

Correct the exit code to be a simple value, rather than two or three separate values stuffed into a single integer.

Closes ipython#2794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants