Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log user tracebacks in the kernel (INFO-level) #2818

Merged
merged 1 commit into from Jan 23, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 20, 2013

Should make debugging errors a little less painful

should close #2473

I don't know why I didn't issue this PR earlier, this fix is from months ago.

@ellisonbg
Copy link
Member

I realize it is nice to have this be possible, but I think that putting these messages at debug level INFO is a bit to aggressive. I would prefer DEBUG. I have tested this and it does what is say it does. I run at INFO level somewhat regularly and wouldn't always want to see my regular user exceptions in the log.

@minrk
Copy link
Member Author

minrk commented Jan 23, 2013

I see your point, but I wanted to draw a line between user exceptions and the massive mostly useless barf that is debug output. Currently there are exactly two messages at the info level (abort and eventloop transition), so I think INFO is actually the right way to go.

@ellisonbg
Copy link
Member

OK, I think that is fine, I think this is ready for merge then.

On Wed, Jan 23, 2013 at 10:43 AM, Min RK notifications@github.com wrote:

I see your point, but I wanted to draw a line between user exceptions and
the massive mostly useless barf that is debug output. Currently there are
exactly two messages at the info level (abort and eventloop transition), so
I think INFO is actually the right way to go.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2818#issuecomment-12615109.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@ellisonbg
Copy link
Member

Ahh yes, I forgot that the kernel truly barfs everyting in DEBUG mode. We should probably fix that as it is too verbose to be useful for anything. Good call.

@minrk
Copy link
Member Author

minrk commented Jan 23, 2013

debug output is a challenge - if we got rid of that information, we would have no access to it if we were having problems with messaging. It makes sense for there to be a way to see all of the message traffic, but perhaps we would need a separate debug_all_messages flag, rather than implying this simply with the debug log-level.

minrk added a commit that referenced this pull request Jan 23, 2013
log user tracebacks in the kernel (INFO-level)

Should make debugging errors a little less painful

closes #2473
@minrk minrk merged commit 4838344 into ipython:master Jan 23, 2013
@minrk minrk deleted the log_exception branch March 31, 2014 23:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
log user tracebacks in the kernel (INFO-level)

Should make debugging errors a little less painful

closes ipython#2473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages in ipengine/ipcontroller
2 participants