Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add '=' to greedy completer delims #2820

Merged
merged 1 commit into from Jan 23, 2013
Merged

add '=' to greedy completer delims #2820

merged 1 commit into from Jan 23, 2013

Conversation

minrk
Copy link
Member

@minrk minrk commented Jan 20, 2013

closes #2657

Commit credited to @klonuo for the patch

closes ipython#2657

Signed-off-by: MinRK <benjaminrk@gmail.com>
@ellisonbg
Copy link
Member

OK, let's try this again:

Seems like the is a bigger issue with the greedy completer and that this PR will not fix that bigger issue. Do we want to close this and open an issue for the larger issue? Or will we try to use this PR to address the bigger issue?

@minrk
Copy link
Member Author

minrk commented Jan 23, 2013

Definitely not close. It may be that we want to address the larger issue of how the greedy completer works at some point, but there are no circumstances under which this is not an improvement, so it would be silly to close it.

@ellisonbg
Copy link
Member

Do you want to try to do more work on the bigger issue or do you think this
can go in as is. I did test it and verified is fixes the = issue.

On Wed, Jan 23, 2013 at 10:36 AM, Min RK notifications@github.com wrote:

Definitely not close. It may be that we want to address the larger issue
of how the greedy completer works at some point, but there are no
circumstances under which this is not an improvement, so it would be silly
to close it.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2820#issuecomment-12614723.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member Author

minrk commented Jan 23, 2013

Let's merge this, but allow #2657 to stay open to track the larger issue.

@ellisonbg
Copy link
Member

Sounds good.

On Wed, Jan 23, 2013 at 10:45 AM, Min RK notifications@github.com wrote:

Let's merge this, but allow #2657https://github.com/ipython/ipython/issues/2657to stay open to track the larger issue.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2820#issuecomment-12615185.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

minrk added a commit that referenced this pull request Jan 23, 2013
add '=' to greedy completer delims
@minrk minrk merged commit 95d5538 into ipython:master Jan 23, 2013
@minrk minrk deleted the greedydelim branch January 23, 2013 18:55
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
add '=' to greedy completer delims
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tab auto-completion fails if there is no space
3 participants