Clean up notebook Javascript #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completely decouples the connection failed event in kernel.js from its handling in notificationarea.js.
| var ws_url = data.ws_url; | ||
| var early = data.early; | ||
| var msg; | ||
| console.log(early); |
I have also cleaned up some calls to console.log.
* Removed Tooltip._cmfocus as it was doing nothing. * Removed debug console.log in notification area.
|
While you are refactoring. Unless you know a such a lib... |
|
What about |
|
Otherwise, ok for me. |
|
@Carreau I think for now I am going to leave it as cell, because tooltip only works with codecells. If the MD cells become more kernel aware, we can fix that then. Merging. |
ellisonbg
added a commit
that referenced
this pull request
Jan 23, 2013
Clean up notebook Javascript
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Clean up notebook Javascript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of spots where the CodeCell logic depended on the IPython.notebook object. These have been removed. I have also cleaned up some of the css that was having problems when CodeCells are embedded onto bootstrap containing pages. This will help us as we refactor the notebook to use bootstrap. Finally I have further decoupled the Kernel object from everything else and improved its reconnection logic.