get monospace pager back #2885
Merged
get monospace pager back #2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
output_area and output_stream seem like entirely wrong classes for the pager area. @ellisonbg do you know why they would have been there? |
|
@minrk no he does not remember. And I think it is due to copy/past code at the time the pager was created. |
|
Okay, then go ahead and merge, I think. |
|
Great, merging. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
get monospace pager back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, pager is not monospaced anymore.
removing those class seem to fix it.
Do anybody have any idea why they where here in the first place ?
Except docstring and
%pycat, I dont see what could use output_area and output stream in the pager.