New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inputhook_wx on osx #2901
Fix inputhook_wx on osx #2901
Conversation
To save other people a moment, we have
At present, we use |
I vote for merging this as-is, since the situation is just unusable now. We can look into a better fix if people continue to report trouble with wx. |
I agree with @minrk that this should be merged as is. @takluyver do you agree? |
I'm not on OS X, so I can't test it. ;-) But if |
OK I am going to merge. |
Use the inputhook_wx2 implementation on osx, fixing #2762. Please review. Perhaps it would be better to test with `'cocoa' in wx.version()`, write a new implementation without the Pending/Dispatch loop, or just use inputhook_wx2 on all platforms.
Use the inputhook_wx2 implementation on osx, fixing #2762. Please review. Perhaps it would be better to test with `'cocoa' in wx.version()`, write a new implementation without the Pending/Dispatch loop, or just use inputhook_wx2 on all platforms.
Fix inputhook_wx on osx
Use the inputhook_wx2 implementation on osx, fixing #2762.
Please review. Perhaps it would be better to test with
'cocoa' in wx.version()
, write a new implementation without the Pending/Dispatch loop, or just use inputhook_wx2 on all platforms.