fix qtconsole history logic for end-of-line #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndOfLine may or may not mean the end of a full line when the line is longer than the window. This commit uses the same logic to check as the actual move, so it should be consistent. closes ipython#2943
|
From the comment of #2943, I would say +1. |
|
I have verified that this does fix the bug, merging. |
ellisonbg
added a commit
that referenced
this pull request
Feb 20, 2013
fix qtconsole history logic for end-of-line
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix qtconsole history logic for end-of-line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EndOfLine may or may not mean the end of a full line when the line is longer
than the window. This commit uses the same logic to check as the actual move,
so it should be consistent.
closes #2943