Added assert msg to extract_hist_ranges() #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -776,7 +776,8 @@ def extract_hist_ranges(ranges_str): | |||
| endsess = rmatch.group("endsess") or startsess | |||
| startsess = int(startsess.replace("~","-")) | |||
| endsess = int(endsess.replace("~","-")) | |||
| assert endsess >= startsess | |||
| assert endsess >= startsess, ("start session must be older than end " | |||
| "session") | |||
There was a problem hiding this comment.
In cases like this, just go a few characters over the end of the line. We're not too strict about line limits, and this just looks awkward.
takluyver
added a commit
that referenced
this pull request
Feb 22, 2013
Added assert msg to extract_hist_ranges()
|
Thanks, merged. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Added assert msg to extract_hist_ranges()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added informative message to the
assert endsess >= startsessinextract_hist_ranges()