Add info make target that was missing in old Sphinx #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| info: | ||
| mkdir -p $(BUILDDIR)/texinfo | ||
| $(SPHINXBUILD) -b texinfo $(ALLSPHINXOPTS) $(BUILDDIR)/texinfo |
There was a problem hiding this comment.
Shouldn't this task depend on the texinfo task, rather than repeating its recipe?
There was a problem hiding this comment.
I think you are right but this is what sphinx puts in Makefile by default. I guess sphinx does not use dependency handling in make. For example, in principle nearly all targets should depend on pickle but they do not, right?
There was a problem hiding this comment.
If it's just copied from Sphinx, that's fair enough. Perhaps they have a good reason to do it like this. I have a feeling make can't track a directory of files as one target: perhaps that's it.
|
Reading the discussion I would guess this is ok for merge. +1 for merge. |
|
works for me. Merging. |
minrk
added a commit
that referenced
this pull request
Mar 27, 2013
Add info and texinfo make targets that were missing in old Sphinx
|
Thanks :) |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Add info and texinfo make targets that were missing in old Sphinx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Emacs users.