Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notebook.js documentation #3076

Merged
merged 2 commits into from Mar 25, 2013

Conversation

dwyde
Copy link
Contributor

@dwyde dwyde commented Mar 25, 2013

I added YUIDoc comments to all of the methods in notebook.js.

The only code I changed was to remove an unused parameter from the ncells() method.

@Carreau
Copy link
Member

Carreau commented Mar 25, 2013

Oh ! Great ! Docs only PR are really rare ! Kudos !

I'll read a little just in case, and also to give others the time to see this PR.

@Carreau
Copy link
Member

Carreau commented Mar 25, 2013

Thanks a lot !
I'll merge it!

Carreau added a commit that referenced this pull request Mar 25, 2013
@Carreau Carreau merged commit 699a45a into ipython:master Mar 25, 2013
@minrk
Copy link
Member

minrk commented Mar 25, 2013

Just stepping in to add - hooray for docs PRs!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants