fix regular expression for detecting links in stdout #3078
Merged
+3
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous expression was matching both the beginning and the end of the line, which would end up swallowing the next match, ultimately matching every other URL in the string. This removes the end-of-line check, so it will match every URL. The wrapURLs function to make URLs easier to identify does not seem to have been necessary, and has thus been removed. closes ipython#2834
|
This looks clean to me, thanks! @satra, could you take it for a quick spin to see how it does for the cases where you were seeing problems? Since we're stuck in the dark ages with no tests for JS, I'd like confirmation from you before merging... |
|
works for me after clearing the cache. a simple test would be to do: and check that the output cell contains two |
|
Looks fine, and seeing the above comment, merging. |
Carreau
added a commit
that referenced
this pull request
Mar 27, 2013
fix regular expression for detecting links in stdout
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix regular expression for detecting links in stdout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous expression was matching both the beginning and the end of the line, which would end up swallowing the next match, ultimately matching every other URL in the string.
This removes the end-of-line check, so it will match every URL.
The wrapURLs function to make URLs easier to identify does not seem to have been necessary, and has thus been removed.
closes #2834