Default color output for ls on OSX

[boxed]

Also fixed incorrect overriding of ls alias on OSX which prevented producing color output.

[boxed]

I'm a bit unsure of the change I made for avoiding aliases to get overwritten. It seems to me that there might be cases where you DO want aliases to be overwritten that my change will stop. I'm not sure how you should differentiate between these cases.

[minrk]

OS X does not behave differently from BSD here, so we don't need to add an extra branch, we just needed to add -Gto the BSD, OS X, etc. branch.

[boxed]

Aha. Fixed now.

[minrk]

I can't imagine a case where an alias should be overwritten by a regular executable on the path. The point of aliases is to emulate bash aliases, which always take precedence over items on your path (as far as I know, anyway).

[boxed]

Well it happens on my machine... I tried changing the code like this:

                                if ff in self.shell.alias_manager.alias_table:
                                    print "'%s' overwrites %s" % (ff, self.shell.alias_manager.alias_table[ff])
                                self.shell.alias_manager.define_alias(
                                    ff.replace('.',''), ff)

..and it prints

'clear' overwrites (0, 'clear')
'less' overwrites (0, 'less')
'man' overwrites (0, 'man')
'more' overwrites (0, 'more')
'cat' overwrites (0, 'cat')
'cp' overwrites (0, 'cp -i')
'ls' overwrites (0, 'ls -G')
'mkdir' overwrites (0, 'mkdir')
'mv' overwrites (0, 'mv -i')
'rm' overwrites (0, 'rm -i')
'rmdir' overwrites (0, 'rmdir')
'easy_install' overwrites (0, 'easy_install')
'freetype-config' overwrites (0, 'freetype-config')
'libpng-config' overwrites (0, 'libpng-config')

[minrk]

Sorry, I meant that I can't imagine a case where that's the right behavior - you said you were unsure about your change preventing the code from overwriting aliases with items on the path, and I only meant to say that I can't think of a situation where your change is not the right answer. Basically, a circuitous and unclear +1 to the change.

[boxed]

Aha. Cool :)

On 8 apr 2013, at 22:33, Min RK notifications@github.com wrote:

Sorry, I meant that I can't imagine a case where that's the right behavior - you said you were unsure about your change preventing the code from overwriting aliases with items on the path, and I only meant to say that I can't think of a situation where your change is not the right answer. Basically, a circuitous and unclear +1 to the change.

—
Reply to this email directly or view it on GitHub.

[ellisonbg]

Yeah colored ls. This looks good, I am merging.