Fix small inconsistency in nbconvert: etype -> ename #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks correct to me. @ivanov does this affect what you were working on? |
|
yes it does, thanks for the heads up, Min! |
ivanov
added a commit
to ivanov/vim-ipython
that referenced
this pull request
Apr 16, 2013
|
By the way, do you actually send "crash" messages as described in the messaging protocol? I was looking through the notebook code and didn't find any mention of it. |
|
@maximsch2 - no, we do not send crash messages. That is just an old proposal in the 'future ideas' section, it has not been implemented. |
minrk
added a commit
that referenced
this pull request
Apr 24, 2013
Fix small inconsistency in nbformat: etype -> ename We call this ename everywhere else, including in notebook files.
ivanov
added a commit
to ivanov/vim-ipython
that referenced
this pull request
Feb 8, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix small inconsistency in nbformat: etype -> ename We call this ename everywhere else, including in notebook files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All .ipynb files I've looked at have "ename" field, not "etype". That's also what is being sent from the kernel to the notebook.